52 Commits

Author SHA1 Message Date
a79ae2d50f Apply new features from branch 'dev' into jenkins-pipeline 2025-06-12 18:42:28 +00:00
cd4ab3fd27 Handled more errors during db initialization 2025-06-12 18:42:07 +00:00
301cf5922e Changed docker image base to Alpine and added curl 2025-06-11 22:15:37 +00:00
479ec4f917 Added healthcheck 2025-06-11 22:04:35 +00:00
3f40a6126c Added more descriptions of functions 2025-06-11 20:04:04 +00:00
dd9e9ce110 Improved function body 2025-06-11 19:57:15 +00:00
d3d3c98f99 Moved wait_for_db function to utils module 2025-06-11 19:48:58 +00:00
9e010ed389 Implemented waiting for db readiness 2025-06-11 19:43:47 +00:00
d9fe927832 Removed deprecated label option from pipeline 2025-06-11 17:51:55 +00:00
636a382cf5 Deleted jenkins pipeline from main branch 2025-06-11 17:13:27 +00:00
99cfdfddd0 Added annotation required to run Sysbox on pod 2025-06-11 16:52:16 +00:00
f579e440f8 Updated path to pod template yaml file 2025-06-11 16:43:22 +00:00
ba69728c81 Changed pod runtime to sysbox 2025-06-11 16:32:12 +00:00
5366e313c5 Moved Jenkinsfile and pod agent template to separate directory 2025-06-11 16:29:03 +00:00
283be1a1ec Deleted Goss 2025-06-11 16:28:08 +00:00
1b7204c2ba Changed name of variable to store ACR name instead of ACR username 2025-06-10 20:17:25 +00:00
8f9aed299d Added managed identity client id 2025-06-10 19:32:40 +00:00
6522977280 Changed basic auth to managed identity 2025-06-10 18:50:37 +00:00
c707974a2e Corrected agent declaration in Jenkinsfile 2025-06-08 16:56:35 +00:00
cc2f224d60 Moved pod agent code from Jenkins master to YAML file in repo 2025-06-08 16:45:05 +00:00
b14e6cf873 Restored dind container usage 2025-06-07 21:44:24 +00:00
87e3c0df80 Removed Goss tests 2025-06-07 21:14:40 +00:00
aea09a6081 Added bash installation 2025-06-07 15:08:58 +00:00
d05cede409 The command curl is replaced with wget 2025-06-07 15:06:19 +00:00
17162027b6 Removed unnecessary post cleanup 2025-06-07 14:57:35 +00:00
8887f1b2bd Updated Jenkins pipeline to use in Kubernetes 2025-06-07 13:31:03 +00:00
76a351710f Added variable APP_PORT to customize application port 2025-05-04 16:42:43 +00:00
c1f0da4a9c Extended Goss sleep 2025-05-04 15:37:47 +00:00
eefc952ff0 Updated app port in Goss YAML config 2025-05-04 15:26:21 +00:00
8c35b3bd8c Changed development server to production 2025-05-04 15:23:05 +00:00
60011b1c72 Added GOSS_SLEEP flag to wait for container full start before tests 2025-05-04 11:03:12 +00:00
859a962c12 Corrected python command name in Goss config YAML 2025-05-04 11:02:09 +00:00
0e9df4f859 Corrected command to run tests in Goss 2025-05-04 10:14:36 +00:00
1554404657 Corrected port to check in Goss YAML config 2025-05-04 10:14:18 +00:00
925af7d314 Corrected commands to test python app 2025-05-04 06:55:10 +00:00
fb260a0f6d Corrected directory in jenkins pipeline 2025-05-03 20:21:02 +00:00
dcd9a39b46 Corrected shell commands in jenkins pipeline 2025-05-03 20:05:32 +00:00
8194e3e9fe Added Jenkins pipeline to test code and container 2025-05-03 19:47:27 +00:00
0006044ae4 Added goss tests 2025-05-03 19:45:40 +00:00
74a58879ce Refactored code responsible for finding user in database 2025-04-02 20:02:34 +00:00
d325a52222 Refactored test code 2025-04-02 19:28:20 +00:00
546d26ada0 Added test for user edit 2025-04-02 19:22:12 +00:00
acf4b1c26c Added test for user remove 2025-04-02 19:21:48 +00:00
37e89b60af Added test for user logout 2025-03-29 21:18:24 +00:00
2632bdf994 Changed deprecated query.get and query.get_or_404 methods to other equivalents 2025-03-29 21:12:00 +00:00
8637eaa96f Added revoking token during logout 2025-03-29 20:57:01 +00:00
99dd5148b1 Now fabric function creates app 2025-03-29 20:32:38 +00:00
3ad5f0ca94 Added more cases to user tests to check all access levels 2025-03-27 22:38:16 +00:00
0891ba7d87 Added test for user endpoints 2025-03-27 20:01:04 +00:00
3552c251bf Moved utils functions to separate file 2025-03-19 21:02:02 +01:00
31480c5c55 Removed task model 2025-03-19 20:56:15 +01:00
90a7a8a72c Removed task views 2025-03-19 20:06:03 +01:00
13 changed files with 446 additions and 203 deletions

49
.jenkins/Jenkinsfile vendored Normal file
View File

@ -0,0 +1,49 @@
pipeline {
agent {
kubernetes {
yamlFile '.jenkins/podTemplate.yaml'
}
}
environment {
ACR_NAME = 'marcin00'
CLIENT_ID = 'c302726f-fafb-4143-94c1-67a70975574a'
DOCKER_REGISTRY_URL = 'marcin00.azurecr.io'
DOCKER_IMAGE = "${DOCKER_REGISTRY_URL}/user-microservice:${GIT_COMMIT}"
}
stages {
stage('Code Tests') {
steps {
container('python') {
dir('api') {
sh '''
python3 -m venv env
source env/bin/activate
pip install -r requirements.txt pytest
python3 -m pytest --junit-xml=pytest_junit.xml
'''
}
}
}
post {
always {
junit testResults: '**/*pytest_junit.xml'
}
}
}
stage('Build & Push Docker') {
steps {
container('docker') {
sh '''
docker build -t ${DOCKER_IMAGE} .
az login --identity --client-id ${CLIENT_ID}
az acr login --name ${ACR_NAME}
docker push ${DOCKER_IMAGE}
'''
}
}
}
}
}

50
.jenkins/podTemplate.yaml Normal file
View File

@ -0,0 +1,50 @@
apiVersion: v1
kind: Pod
metadata:
annotations:
io.kubernetes.cri-o.userns-mode: "auto:size=65536"
labels:
jenkins: "slave"
jenkins/label: "kubernetes-agent"
spec:
runtimeClassName: sysbox-runc
containers:
- name: jnlp
image: jenkins/inbound-agent:alpine
tty: false
workingDir: /home/jenkins/agent
volumeMounts:
- name: workspace-volume
mountPath: /home/jenkins/agent
env:
- name: JENKINS_WEB_SOCKET
value: "true"
- name: REMOTING_OPTS
value: "-noReconnectAfter 1d"
- name: python
image: python:3.11.7-alpine
command:
- cat
tty: true
workingDir: /home/jenkins/agent
volumeMounts:
- name: workspace-volume
mountPath: /home/jenkins/agent
- name: docker
image: marcin00.azurecr.io/azure-cli-docker:slim-bookworm
tty: true
workingDir: /home/jenkins/agent
volumeMounts:
- name: workspace-volume
mountPath: /home/jenkins/agent
nodeSelector:
kubernetes.io/os: linux
restartPolicy: Never
volumes:
- name: workspace-volume
emptyDir: {}

View File

@ -1,5 +1,6 @@
FROM python:3.11.7-slim-bookworm FROM python:3.11.7-alpine
WORKDIR /app WORKDIR /app
COPY api . COPY api .
RUN apk add --no-cache curl
RUN pip install -r requirements.txt RUN pip install -r requirements.txt
CMD python3 app.py CMD python3 app.py

View File

@ -2,47 +2,69 @@ from dotenv import load_dotenv
from flask import Flask, jsonify from flask import Flask, jsonify
from flask_jwt_extended import JWTManager from flask_jwt_extended import JWTManager
from jwt import ExpiredSignatureError from jwt import ExpiredSignatureError
from models import db from models import db, RevokedToken
import os import os
from task_views import task_bp from tech_views import tech_bp
from user_views import user_bp, init_db from utils import init_db, wait_for_db
from views import user_bp
from werkzeug.exceptions import HTTPException from werkzeug.exceptions import HTTPException
# App initialization def create_app(config_name="default"):
load_dotenv() """Creates and returns a new instance of Flask app."""
app = Flask(__name__) load_dotenv()
app.config['SQLALCHEMY_DATABASE_URI'] = os.getenv('SQLALCHEMY_DATABASE_URI') app = Flask(__name__)
app.config['SQLALCHEMY_TRACK_MODIFICATIONS'] = True
app.config['JWT_SECRET_KEY'] = os.getenv('JWT_SECRET_KEY', 'changeme') # Database settings
if config_name == "testing":
app.config["SQLALCHEMY_DATABASE_URI"] = "sqlite:///:memory:" # Database in memory
app.config["TESTING"] = True
else:
app.config["SQLALCHEMY_DATABASE_URI"] = os.getenv("SQLALCHEMY_DATABASE_URI")
app.config["SQLALCHEMY_TRACK_MODIFICATIONS"] = False
# Blueprints registration # JWT settings
app.register_blueprint(user_bp) app.config["JWT_SECRET_KEY"] = os.getenv("JWT_SECRET_KEY", "changeme")
app.register_blueprint(task_bp)
# Database and JWT initialization # Blueprints registration
db.init_app(app) app.register_blueprint(user_bp)
jwt = JWTManager(app) app.register_blueprint(tech_bp)
# Global error handler # Database and JWT initialization
@app.errorhandler(Exception) db.init_app(app)
def global_error_handler(error): jwt = JWTManager(app)
if isinstance(error, HTTPException):
response = jsonify({"error": error.description}) # Function to check if JWT token is revoked
response.status_code = error.code @jwt.token_in_blocklist_loader
elif isinstance(error, ExpiredSignatureError): def check_if_token_revoked(jwt_header, jwt_payload):
response = jsonify({"error": "Token has expired"}) token = db.session.get(RevokedToken, jwt_payload["jti"])
response.status_code = 401 return token is not None
else: # Wszystkie inne błędy
response = jsonify({"error": str(error)}) # Global error handler
response.status_code = 500 @app.errorhandler(Exception)
return response def global_error_handler(error):
if isinstance(error, HTTPException):
response = jsonify({"error": error.description})
response.status_code = error.code
elif isinstance(error, ExpiredSignatureError):
response = jsonify({"error": "Token has expired"})
response.status_code = 401
else: # All other errors
response = jsonify({"error": str(error)})
response.status_code = 500
return response
# Fill database by initial values (only if we are not testing)
with app.app_context():
wait_for_db(max_retries=100)
db.create_all()
if config_name != "testing":
init_db()
return app
# Fill database by initial values # Server start only if we run app directly
with app.app_context():
db.create_all()
init_db()
# Server start
if __name__ == "__main__": if __name__ == "__main__":
app.run(host='0.0.0.0') from waitress import serve
app = create_app()
port = os.getenv("APP_PORT", "80")
serve(app, host="0.0.0.0", port=port)

View File

@ -16,23 +16,5 @@ class User(db.Model):
def get_editable_fields(): def get_editable_fields():
return {"username", "email", "role", "password"} return {"username", "email", "role", "password"}
class Task(db.Model): class RevokedToken(db.Model):
id = db.Column(db.Integer, primary_key=True, autoincrement=True) jti = db.Column(db.String(100), primary_key=True)
title = db.Column(db.String(100), nullable=False)
description = db.Column(db.Text)
done = db.Column(db.Boolean, default=False)
due_date = db.Column(db.DateTime)
user_id = db.Column(db.Integer, db.ForeignKey('user.id'), nullable=False)
def to_dict(self):
return {
"id": self.id,
"title": self.title,
"description": self.description,
"due_date": self.due_date,
"done": self.done,
}
@staticmethod
def get_editable_fields():
return {"title", "description", "due_date", "done"}

View File

@ -11,4 +11,5 @@ mysql-connector-python==9.2.0
python-dotenv==1.0.0 python-dotenv==1.0.0
SQLAlchemy==2.0.23 SQLAlchemy==2.0.23
typing_extensions==4.8.0 typing_extensions==4.8.0
waitress==3.0.2
Werkzeug==3.0.1 Werkzeug==3.0.1

View File

@ -1,109 +0,0 @@
from datetime import datetime
from flask import Blueprint, jsonify, request, abort
from flask_jwt_extended import jwt_required, get_jwt_identity
from models import Task, db
from user_views import admin_required, validate_access
task_bp = Blueprint('task_bp', __name__)
# ============================================================
# 🚀 1. API ENDPOINTS (ROUTES)
# ============================================================
@task_bp.route('/tasks', methods=['GET'])
@jwt_required()
def get_all_tasks():
admin_required(get_jwt_identity()) # only admin can get all tasks
tasks = Task.query.all()
return jsonify([task.to_dict() for task in tasks])
@task_bp.route('/tasks/<int:task_id>', methods=['GET'])
@jwt_required()
def get_task(task_id):
task = Task.query.get(task_id) # return task or None if task not found
check_if_task_exists(task)
return jsonify(task.to_dict())
@task_bp.route('/tasks/user/<int:user_id>', methods=['GET'])
@jwt_required()
def get_tasks_by_user(user_id):
validate_access(user_id)
tasks = Task.query.filter_by(user_id=user_id).all()
tasks = [task.to_dict() for task in tasks]
return jsonify(tasks)
@task_bp.route('/tasks', methods=['POST'])
@jwt_required()
def create_task():
data = request.get_json()
validate_task_data(data)
due_date = datetime.strptime(data['due_date'], '%d-%m-%Y %H:%M')
task = Task(title=data['title'], description=data['description'], due_date=due_date,
done=data['done'], user_id=get_jwt_identity())
db.session.add(task)
db.session.commit()
return jsonify(task.to_dict())
@task_bp.route('/tasks/<int:task_id>', methods=['PUT', 'PATCH'])
@jwt_required()
def update_task(task_id):
task = Task.query.get(task_id)
check_if_task_exists(task)
request_data = request.get_json()
validate_task_data(request_data)
request_fields = set(request_data.keys())
editable_fields = Task.get_editable_fields()
# PUT requires all values
if request.method == 'PUT':
if request_fields != editable_fields:
abort(400, "Invalid request data structure.")
for field_name in editable_fields:
requested_value = request_data.get(field_name)
if requested_value is None:
continue
new_value = datetime.strptime(requested_value, '%d-%m-%Y %H:%M') \
if field_name == 'due_date' else requested_value
setattr(task, field_name, new_value)
db.session.commit()
return jsonify(task.to_dict())
@task_bp.route('/tasks/<int:task_id>', methods=['DELETE'])
@jwt_required()
def delete_task(task_id):
task = Task.query.get(task_id)
check_if_task_exists(task)
db.session.delete(task)
db.session.commit()
return jsonify({})
# ============================================================
# 🔧 2. UTILITIES
# ============================================================
def check_if_task_exists(task):
# Check if task exists or user has permissions to see it
if task is None:
abort(404, "Task not found.")
user_id = task.user_id
validate_access(user_id)
def validate_task_data(task):
due_date = task.get('due_date')
try:
datetime.strptime(due_date, '%d-%m-%Y %H:%M')
except ValueError:
abort(400, "Incorrect datetime format. Expected DD-MM-YYYY HH:MM")
done = task.get('done')
if done not in (0, 1):
abort(400, "Incorrect done field value. Expected 0 or 1")

20
api/tech_views.py Normal file
View File

@ -0,0 +1,20 @@
from flask import Blueprint, jsonify
from models import db
from sqlalchemy import text
from utils import db_ready
# Blueprint with technical endpoints
tech_bp = Blueprint('tech_bp', __name__)
@tech_bp.route('/health', methods=['GET'])
def health_check():
"Check if service works and database is functional"
try:
with db.engine.connect() as connection:
connection.execute(text("SELECT 1"))
return jsonify(status="healthy"), 200
except Exception:
if db_ready:
return jsonify(status="unhealthy"), 500
else:
return jsonify(status="starting"), 503

47
api/tests/conftest.py Normal file
View File

@ -0,0 +1,47 @@
import pytest
from app import create_app
from flask_jwt_extended import create_access_token
from models import db, User
from werkzeug.security import generate_password_hash
@pytest.fixture
def test_client():
"""Creates a new instance of test app."""
app = create_app("testing")
with app.test_client() as client:
with app.app_context():
db.create_all()
yield client
db.session.remove()
db.drop_all()
@pytest.fixture
def test_user():
"""Create a new user for testing."""
user = User(username="testuser", email="test@example.com", password=generate_password_hash("testpass"), role="User")
db.session.add(user)
db.session.commit()
return user
@pytest.fixture
def test_user2():
"""Create a user nr 2 for testing."""
user2 = User(username="testuser2", email="test2@example.com", password=generate_password_hash("testpass2"), role="User")
db.session.add(user2)
db.session.commit()
return user2
@pytest.fixture
def test_admin():
"""Create a new admin user for testing."""
admin = User(username="adminuser", email="admin@example.com", password=generate_password_hash("adminpass"), role="Administrator")
db.session.add(admin)
db.session.commit()
return admin
def login_test_user(identity):
"""Return Bearer auth header for user identified by provided id"""
access_token = create_access_token(identity=str(identity))
auth_header = {"Authorization": f"Bearer {access_token}"}
return auth_header

132
api/tests/test_users.py Normal file
View File

@ -0,0 +1,132 @@
from conftest import login_test_user
import json
def test_create_user(test_client, test_user, test_admin):
"""New user registration test"""
# Anonymous try to create common user
test_user_data = {"username": "test", "email": "testemail@example.com", "password": "testpassword", "role": "User"}
response = test_client.post("/users", data=json.dumps(test_user_data), content_type="application/json")
assert response.status_code == 201, "Each should can register in the service"
data = response.get_json()
assert data["username"] == "test"
# Anonymous try to create admin user
admin_user_data = {"username": "testadmin", "email": "testadmin@example.com", "password": "adminpass", "role": "Administrator"}
response = test_client.post("/users", data=json.dumps(admin_user_data), content_type="application/json")
assert response.status_code == 401, "Anonymous should cannot create admin users"
# Login common user and try to create admin user
headers = login_test_user(test_user.id)
response = test_client.post("/users", data=json.dumps(admin_user_data), content_type="application/json", headers=headers)
assert response.status_code == 403, "Common user should cannot create admin users"
# Try to create admin user using admin account
headers = login_test_user(test_admin.id)
response = test_client.post("/users", data=json.dumps(admin_user_data), content_type="application/json", headers=headers)
assert response.status_code == 201, "Logged administrators should can create new admin users"
def test_edit_user(test_client, test_user, test_admin):
"User edit test"
# Anonymous cannot edit any user
admin_data = test_admin.to_dict()
response = test_client.patch(f"/users/{test_admin.id}", data=json.dumps({"username": admin_data["username"], "password": "adminpass"}))
assert response.status_code == 401
# Login users (get dict with auth header and merge it with dict with rest of headers)
admin_headers = login_test_user(test_admin.id) | {"Content-Type": "application/json"}
user_headers = login_test_user(test_user.id) | {"Content-Type": "application/json"}
# Check if PUT request contains all editable fields
response = test_client.put(f"/users/{test_user.id}", data=json.dumps({"username": test_user.username, "password": "testpass"}), headers=user_headers)
assert response.status_code == 400, "PUT request data must have all editable fields"
# Check if user can edit their own data
response = test_client.patch(f"/users/{test_user.id}", data=json.dumps({"username": test_user.username, "password": "testpass"}), headers=user_headers)
assert response.status_code == 200, "Common user should can edit own account data"
# Check if user cannot edit other user data
response = test_client.patch(f"/users/{test_admin.id}", data=json.dumps({"username": admin_data["username"], "password": "adminpass"}), headers=user_headers)
assert response.status_code == 403, "Common user should cannot edit other user data"
# Check if admin can edit other user data
response = test_client.patch(f"/users/{test_user.id}", data=json.dumps({"username": test_user.username, "password": "testpass"}), headers=admin_headers)
assert response.status_code == 200, "Admin user should can edit other user data"
def test_remove_user(test_client, test_user, test_user2, test_admin):
"User remove test"
# Anonymous try to remove user
response = test_client.delete(f"/users/{test_user.id}")
assert response.status_code == 401, "Anonymous should cannot remove user account"
# Logged user try to remove other user account
headers = login_test_user(test_user.id)
response = test_client.delete(f"/users/{test_admin.id}", headers=headers)
assert response.status_code == 403, "Common user should cannot remove other user account"
# Logged user try to remove own account
response = test_client.delete(f"/users/{test_user.id}", headers=headers)
assert response.status_code == 200, "Common user should can remove their own account"
# Logged admin can remove other user account
admin_headers = login_test_user(test_admin.id)
response = test_client.delete(f"/users/{test_user2.id}", headers=admin_headers)
assert response.status_code == 200, "Admin user should can remove other user account"
def test_login(test_client, test_user):
"""User login test"""
response = test_client.post(
"/login",
data=json.dumps({"username": "testuser", "password": "wrongpass"}),
content_type="application/json",
)
assert response.status_code == 401, "User should not become logged if provided wrong password"
response = test_client.post(
"/login",
data=json.dumps({"username": "testuser", "password": "testpass"}),
content_type="application/json",
)
assert response.status_code == 200, "User should become logged if provided right password"
def test_get_users(test_client, test_user, test_admin):
"""Get all users test"""
response = test_client.get("/users")
assert response.status_code == 401, "Anonymous should cannot get all users data"
# Common user try to get all users data
headers = login_test_user(test_user.id)
response = test_client.get("/users", headers=headers)
assert response.status_code == 403, "Common user should cannot get all users data"
# Admin user try to get all users data
headers = login_test_user(test_admin.id)
response = test_client.get("/users", headers=headers)
assert response.status_code == 200, "Admin user should be able to get all users data"
def test_get_user_with_token(test_client, test_user, test_admin):
"""Test to get user data before and after auth using JWT token"""
response = test_client.get(f"/users/{test_admin.id}")
assert response.status_code == 401, "Anonymous should cannot get user data without login"
admin_headers = login_test_user(test_admin.id)
response = test_client.get(f"/users/{test_admin.id}", headers=admin_headers)
assert response.status_code == 200
data = response.get_json()
assert data["username"] == "adminuser"
headers = login_test_user(test_user.id)
response = test_client.get(f"/users/{test_user.id}", headers=headers)
assert response.status_code == 200, "Common user should can get own user data"
response = test_client.get(f"/users/{test_admin.id}", headers=headers)
assert response.status_code == 403, "Common user should cannot get other user data"
response = test_client.get(f"/users/{test_user.id}", headers=admin_headers)
assert response.status_code == 200, "Admin should can access all user data"
def test_user_logout(test_client, test_user):
"""Test if logout works and JWT token is revoked"""
headers = login_test_user(test_user.id)
response = test_client.get(f"/logout", headers=headers)
assert response.status_code == 200, "Logged user should can logout"
response = test_client.get(f"/logout", headers=headers)
assert response.status_code == 401, "Token should be revoked after logout"

59
api/utils.py Normal file
View File

@ -0,0 +1,59 @@
from flask import abort
from flask_jwt_extended import get_jwt_identity
from models import User, db
import os
from sqlalchemy import text
from sqlalchemy.exc import DatabaseError, InterfaceError
import time
from werkzeug.security import generate_password_hash
db_ready = False
def admin_required(user_id, message='Access denied.'):
"Check if common user try to make administrative action."
user = db.session.get(User, user_id)
if user is None or user.role != "Administrator":
abort(403, message)
def validate_access(owner_id, message='Access denied.'):
"Check if user try to access or edit resource that does not belong to them."
logged_user_id = int(get_jwt_identity())
logged_user_role = db.session.get(User, logged_user_id).role
if logged_user_role != "Administrator" and logged_user_id != owner_id:
abort(403, message)
def get_user_or_404(user_id):
"Get user from database or abort 404"
user = db.session.get(User, user_id)
if user is None:
abort(404, "User not found")
return user
def wait_for_db(max_retries):
"Try to connect with database <max_retries> times."
global db_ready
for _ in range(max_retries):
try:
with db.engine.connect() as connection:
connection.execute(text("SELECT 1"))
db_ready = True
return
except DatabaseError | InterfaceError:
time.sleep(3)
raise Exception("Failed to connect to database.")
def init_db():
"""Create default admin account if database is empty"""
with db.session.begin():
if not User.query.first(): # Check if user table is empty
admin_username = os.getenv("ADMIN_USERNAME", "admin")
admin_email = os.getenv("ADMIN_EMAIL", "admin@example.pl")
admin_password = os.getenv("ADMIN_PASSWORD", "admin")
hashed_password = generate_password_hash(admin_password)
admin = User(username=admin_username, email=admin_email, password=hashed_password, role='Administrator')
db.session.add(admin)
db.session.commit()

View File

@ -1,13 +1,14 @@
from flask import Blueprint, jsonify, request, abort from flask import Blueprint, jsonify, request, abort
from flask_jwt_extended import create_access_token, set_access_cookies, jwt_required, verify_jwt_in_request, get_jwt_identity, unset_jwt_cookies from flask_jwt_extended import create_access_token, set_access_cookies, jwt_required, \
from models import User, db verify_jwt_in_request, get_jwt_identity, unset_jwt_cookies, get_jwt
import os from models import db, RevokedToken, User
from utils import admin_required, validate_access, get_user_or_404
from werkzeug.security import check_password_hash, generate_password_hash from werkzeug.security import check_password_hash, generate_password_hash
user_bp = Blueprint('user_bp', __name__) user_bp = Blueprint('user_bp', __name__)
# ============================================================ # ============================================================
# 🚀 1. API ENDPOINTS (ROUTES) # API ENDPOINTS (ROUTES)
# ============================================================ # ============================================================
@user_bp.route('/users', methods=['GET']) @user_bp.route('/users', methods=['GET'])
@ -22,7 +23,7 @@ def get_all_users():
@jwt_required() @jwt_required()
def get_user(user_id): def get_user(user_id):
validate_access(user_id) # check if user tries to read other user account details validate_access(user_id) # check if user tries to read other user account details
user = User.query.get_or_404(user_id) user = get_user_or_404(user_id)
return jsonify(user.to_dict()) return jsonify(user.to_dict())
@ -56,7 +57,7 @@ def edit_user(user_id):
if request_fields != editable_fields: if request_fields != editable_fields:
abort(400, "Invalid request data structure.") abort(400, "Invalid request data structure.")
user_to_update = User.query.get_or_404(user_id) user_to_update = get_user_or_404(user_id)
for field_name in editable_fields: for field_name in editable_fields:
requested_value = request_data.get(field_name) requested_value = request_data.get(field_name)
if requested_value is None: if requested_value is None:
@ -72,7 +73,7 @@ def edit_user(user_id):
@jwt_required() @jwt_required()
def remove_user(user_id): def remove_user(user_id):
validate_access(user_id) # Only admin can remove other users accounts validate_access(user_id) # Only admin can remove other users accounts
user_to_delete = User.query.get_or_404(user_id) user_to_delete = get_user_or_404(user_id)
db.session.delete(user_to_delete) db.session.delete(user_to_delete)
db.session.commit() db.session.commit()
return jsonify({"msg": "User removed successfully."}) return jsonify({"msg": "User removed successfully."})
@ -102,37 +103,10 @@ def user_login():
@user_bp.route('/logout', methods=['GET']) @user_bp.route('/logout', methods=['GET'])
@jwt_required() @jwt_required()
def user_logout(): def user_logout():
jti = get_jwt()["jti"]
revoked_token = RevokedToken(jti=jti)
db.session.add(revoked_token)
db.session.commit()
response = jsonify({"msg": "User logged out successfully."}) response = jsonify({"msg": "User logged out successfully."})
unset_jwt_cookies(response) unset_jwt_cookies(response)
return response return response
# ============================================================
# 🔧 2. UTILITIES
# ============================================================
def admin_required(user_id, message='Access denied.'):
user = User.query.get(user_id)
if user is None or user.role != "Administrator":
abort(403, message)
def validate_access(owner_id, message='Access denied.'):
# Check if user try to access or edit resource that does not belong to them
logged_user_id = int(get_jwt_identity())
logged_user_role = User.query.get(logged_user_id).role
if logged_user_role != "Administrator" and logged_user_id != owner_id:
abort(403, message)
def init_db():
"""Create default admin account if database is empty"""
with db.session.begin():
if not User.query.first(): # Check if user table is empty
admin_username = os.getenv("TODOLIST_ADMIN_USERNAME", "admin")
admin_email = os.getenv("TODOLIST_ADMIN_EMAIL", "admin@example.pl")
admin_password = os.getenv("TODOLIST_ADMIN_PASSWORD", "admin")
hashed_password = generate_password_hash(admin_password)
admin = User(username=admin_username, email=admin_email, password=hashed_password, role='Administrator')
db.session.add(admin)
db.session.commit()

View File

@ -7,9 +7,24 @@ services:
build: . build: .
env_file: env_file:
- api/.env - api/.env
ports:
- 80:80
healthcheck:
test: ["CMD", "curl", "-f", "http://localhost/health"]
interval: 10s
timeout: 5s
retries: 5
start_period: 15s
db: db:
container_name: db container_name: db
hostname: db hostname: db
image: mysql:latest image: mysql:latest
env_file: env_file:
- db/.env - db/.env
ports:
- 3306:3306
healthcheck:
test: ["CMD", "mysqladmin", "ping", "-h", "localhost"]
interval: 10s
timeout: 5s
retries: 5